search

pimutils / vdirsyncer

📇 Synchronize calendars and contacts.
https://vdirsyncer.pimutils.org/
Other
1.51k stars 156 forks source link

fix(repair_collection): use DiscoverResult logic to discover collection (#1019) #1081

Closed croissong closed 11 months ago

croissong commented 11 months ago

Fixes error: DAVSession.__init__() missing 1 required keyword-only argument: 'connector' (#1019). Reuses the existing logic in DiscoverResult to determine if the storage requires a connector arg.

Please let me know if there are any tests that I can extend without too much effort :)

WhyNotHugo commented 11 months ago

Do you want to add an entry to CHANGELOG.rst for 0.19.3? Feel free to add yourself to AUTHORS.rst as well.

croissong commented 11 months ago

done :heavy_check_mark: Not sure if this bug affected only DAV or also other storage backends.

WhyNotHugo commented 11 months ago

I think it affected only dav; I could not reproduce the issue with a filesystem storage.

WhyNotHugo commented 11 months ago

Thanks!

zetoph commented 4 months ago

Hello, thanks a lot for this fix, it works perfectly! Do you already know when this might be published to the pip or apt repos? When installing using those, I still get the old version. br