Expose peer address to handler functions

pin / tftp

TFTP server and client library for Golang

MIT License

287 stars 71 forks source link

Expose peer address to handler functions #24

Closed acd closed 8 years ago

pin commented 8 years ago

LGTM!

If you have time please mention that {Incoming,Outgoing}Transfer exposes remote address (for logging purposes I assume). Also while you are there don't forget to add yourself to CONTRIBUTORS file :+1:

If not will merge it as is and do that myself before cutting next release soon.

pin commented 8 years ago

On "mention" I mean updating godoc comment for that two types. Thanks!

acd commented 8 years ago

Will do. And yes, I made this change to facilitate client IP logging when implementing a server.

pin commented 8 years ago

Looks great! :+1: