pin / tftp

TFTP server and client library for Golang
MIT License
289 stars 74 forks source link

Variable block size logic does not work #61

Closed mtniehaus closed 2 years ago

mtniehaus commented 3 years ago

When using the latest code from /pin/tftp, the block size used for tftp transfers (at least on a Windows Server 2016 OS) would always be negotiated by the go logic to 512 bytes, even when the client would indicate that it supports larger block sizes.

The logic was modified to use the largest possible block size, either as configured by callers to the go routines, or as limited by the client options specified to the service.

pin commented 2 years ago

Thanks @mtniehaus!