mqtt.cpp subscribeToTopic() memory leak

[WSchimi]

Hi Pina, sorry for my code reading ;-)

Pointer char* fullTopicStr is only valid in this function and points to allocated memory that is to be released again in this function with free(fullTopicStr).

void subscribeToTopic(const char* topic, void (*callback)(char*)) {
    if (!wifiIsConnected || !mqttClient.connected()) return;
    char* fullTopicStr = createFullTopicStr(topic); // <--- pointer *fullTopicStr is valid only in this function/method
    mqttClient.subscribe(fullTopicStr);
    SubscribedMqttTopic* newTopic = new SubscribedMqttTopic(fullTopicStr, callback);
    SubscribedMqttTopicList* newTopicListElem = new SubscribedMqttTopicList(
        newTopic, subscribedTopicsList);
    subscribedTopicsList = newTopicListElem;
    logger.printf("Subscribed to MQTT-topic: %s\n", fullTopicStr); /* <--- after this line, add */ free(fullTopicStr);
}

[WSchimi]

Hello Pina, Sorry, i didn't see the SubscribedMqttTopic (fullTopicStr, callback) where fullTopicStr is assigned to the private pointer topic and the memory is used for the entire runtime. I close this issue. Best Regards Walter