search

pinano-discord / Pinano-Discord-Bot

A Discord bot for the Pinano guild
MIT License
9 stars 11 forks source link

Go live permission handling #168

Closed Juliacare closed 4 years ago

Juliacare commented 4 years ago

Deny go live on default for practice rooms and grant the permission to the person whoever owns the lock of said voice channel.

Juliacare commented 4 years ago

see https://discordapp.com/developers/docs/topics/permissions its named STREAM

pianiststickman commented 4 years ago

STREAM is not implemented in discord.js. Is this actually an issue? If someone goes live in a locked room but is muted anyway, do we care?

Juliacare commented 4 years ago

If someone goes live in a locked room but is muted anyway, do we care?

yes as the person's mic is muted, their livestream will still be audible. I do the same with the watchtogether event, where I'm muted yet everyone can still hear my stream.

pianiststickman commented 4 years ago

What happens if they are server muted?

Juliacare commented 4 years ago

then they can still go live however not screenshare without going live. So it wont be a direct interference from another audio source however it does look weird / a little misleading to have someone be live (Streaming whatever) in the same channel someone is practicing.

(just tested it with Waler)

Juliacare commented 4 years ago

Closing issue until it actually becomes an issue