pinano-discord / Pinano-Discord-Bot

A Discord bot for the Pinano guild
MIT License
9 stars 11 forks source link

Consider instantiating new users only on VC end, not all VC and message events #17

Closed pianiststickman closed 5 years ago

pianiststickman commented 5 years ago

Right now there are over a thousand users who have zero weekly practice time, and probably almost as many with zero overall practice time. We are currently instantiating new users as soon as they 1) send a message in any channel or 2) hop into a practice room at all. This means that you can get into the top third of weekly practicers by unmuting yourself for a second. This also makes the full lb sort that happens every time p!lb or p!stats is called unnecessarily long.

As part of this, consider removing users with 0s weekly and 0s overall time.

If we do this we will probably end up with users that have 0s on weekly but >0s on overall so we would probably want to filter those out in the lb.

pianiststickman commented 5 years ago

Fixed in #72