search

pinano-discord / Pinano-Discord-Bot

A Discord bot for the Pinano guild
MIT License
9 stars 11 forks source link

Leaving guild member with room locked can cause p!rooms failure #85

Closed pianiststickman closed 4 years ago

pianiststickman commented 5 years ago

Workaround is to issue p!unlock on the room, but it's hard to tell which room is ghost-locked without having p!rooms working, of course.

pianiststickman commented 5 years ago

So, this no longer crashes p!rooms (or its replacement in the real-time display).

Rooms can still be ghost-locked so the fix here is to run the voiceStateUpdate logic for members leaving channels upon guildMemberRemove. (The simplicity of this may depend on whether or not the ghost GuildMember still has a reference to the VoiceChannel - if so, this is an easy refactoring.)

pianiststickman commented 4 years ago

Fixed in #136