search

pinax / django-flag

flagging of inapproriate/spam content
MIT License
74 stars 44 forks source link

Fixed GenericForeignKey field import error. #13

Closed hramezani closed 5 years ago

hramezani commented 5 years ago

Fixes #11

still does not work with django2.2(on_delete needs to be added). no tests

Do you have a plan to continue this project? If so, I can help you.

KatherineMichel commented 5 years ago

Thank you for your PR, @hramezani!

As far as I know, any Pinax project can be continued, except for the ones clearly marked as deprecated. We would love to have help with this project. There are a lot of updates that can be made to it.

In spring 2018, we completed the 18.01 release. django-flag was not part of the release, so the 18.01 release updates have not been made to it. You can see info at this link about what updates that release involved: https://github.com/pinax/pinax/wiki/Pinax-19.xx-Proposed-Process#pinax-1801-release-overview

I'm planning a new release. The planning notes are in that same doc. The new release process is not finalized yet. For one thing, we might like to switch to GitHub Actions CI instead of CircleCI. https://github.com/pinax/pinax/wiki/Pinax-19.xx-Proposed-Process

We usually use tox (and optionally, a Makefile) to test the matrix. This repo does not include a tox.ini yet, but it's something we would plan to add at some point, including 2.2 so that we could check the updates against the matrix (we plan to add support for Django 2.1, 2.2 and Python 3.7 in 19.xx release).

And of course, tests would be great to have.

By the way, Pinax uses double quotes. This is a style choice made by the creators.

Let me know if you have questions.

hramezani commented 5 years ago

We can close this PR. I will include these changes in #14 .