pinax / pinax-blog

a blog app for Django
MIT License
464 stars 153 forks source link

Validate all fields when saving Post model #100

Closed grahamu closed 7 years ago

grahamu commented 7 years ago

Update slug field to be same length as title field.

Invoke self.full_clean() in Post.save() method to validate all fields which were not validated during form cleaning (if any).

Update documentation to include pinax-images dependency. Add Django v1.10 to testing matrix. Remove Django "master" (latest dev branch) from testing matrix.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.4%) to 61.263% when pulling 34cc699fd18166ece2e41522228343388a643ec8 on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.4%) to 61.263% when pulling 34cc699fd18166ece2e41522228343388a643ec8 on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.4%) to 61.263% when pulling 47e4860562db124b4dda18dfdb5daec1f15bddfb on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.4%) to 61.263% when pulling 3ecef4ccebbcc8b88ed42a9699cc4110709880ee on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.4%) to 61.263% when pulling 3ecef4ccebbcc8b88ed42a9699cc4110709880ee on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.502% when pulling c023b6f21e57404a46314434fdf713b6a77c6584 on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.502% when pulling 1f07c870e72a21706aecc4eafc54f278508302ad on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.502% when pulling 758c2a6a4a612074ed5534f6a1bc0c9eff333fcf on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.502% when pulling a36ba49ac6f28c12e1b336c8a05dcab7dae61b5b on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.502% when pulling 56ccbf008a0f98efbc85bd321a846155c144b862 on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

paltman commented 7 years ago

Looks good to me except, I don't think markup should have blank=True. Was that intentional?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.548% when pulling f451f4aceeb6b74104ece003dcc581db2e2863e8 on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+5.7%) to 61.548% when pulling d4b88d085915a20240d8ed84c862f64d0aa68688 on slug-and-markup into 7843d043fff7c3023457237e67c9aa1d45c5765b on master.