js missing in packaging

pinax / pinax-blog

a blog app for Django

MIT License

464 stars 153 forks source link

js missing in packaging #112

Closed shaib closed 6 years ago

shaib commented 6 years ago

This is mostly a continuation of #103 -- that issue was closed because the HTML templates are, indeed, in pinax.templates. However, static/js/admin_post_form.js which was also mentioned there, is not in pinax.templates, is included in this git repo, and is missing -- at least by default; we've had to install it manually to prevent errors at the post admin page.

I think it needs to be included.

pjmcdermott commented 6 years ago

Confirmed: I have also experienced this

grahamu commented 6 years ago

I wonder if the fix is as simple as

relocate admin_post_form.js to static/src/js/, as seen here
update the appconf ADMIN_JS location to "src/js/admin_post_form.js" here

Then publish a new version, instructing upgrading users to npm install or whatever (I'm not sure!) after upgrading. How does that sound @paltman?

paltman commented 6 years ago

I've thought about actually removing it and providing instructions on how to add it with a gist of sample js.

paltman commented 6 years ago

What I really want to see happen for pinax-blog is an authoring interface outside of the Django admin.

pjmcdermott commented 6 years ago

Isn't the issue simply that the javascript file is not making it into the pypi package? django.contrib.staticfiles.finders.AppDirectoriesFinder provides a perfectly good mechanism to move JS files into a central location.

I don't understand the mechanism, but my pip installed version of pinax-blog simply doesn't have the static folder.

paltman commented 6 years ago

Fixed in v7.0.4 (just pushed to PyPI)