search

pinax / pinax-documents

a document management app for Django
MIT License
65 stars 20 forks source link

Implement document deletion #3

Closed jacobwegner closed 8 years ago

jacobwegner commented 8 years ago

The document_delete view doesn't actually delete the Document model.

In addition, I think it is reasonable to remove the file from disk/project's storage backend, probably implemented with a pre_delete signal.

ethankent commented 8 years ago

Hi,

I have a pull request out for this: https://github.com/pinax/pinax-documents/pull/17, but it's failing because it requires another pull request: https://github.com/pinax/pinax-theme-bootstrap/pull/115

ethankent commented 8 years ago

Looks like everything is up-to-date now. Thanks for your help. I think we could probably even close off this issue and check it off the Milestone List: https://github.com/pinax/pinax-starter-projects/wiki/Groupware-Starter-Project

paltman commented 8 years ago

@ethankent Awesome! Just one more left for pinax-documents. Nice work!