pinax / pinax-models

Provide Support for Logical Deletes on Models and in the Django Admin
http://pypi.python.org/pypi/pinax-models
MIT License
90 stars 25 forks source link

Fix deletion of inherited models #18

Open ron8mcr opened 7 years ago

ron8mcr commented 7 years ago

As referenced in #13, not all related objects should be deleted.

But I think that ForeignKey should resolve it by itself, using on_delete param. The same applies to OneToOneField.

But there is another case with inherited models. Consider following case:

class BaseModel(LogicalDeleteModel):
    name = models.CharField(default='Empty name', max_length=256)

class InhertedModel(BaseModel):
    description = models.TextField(default='Some description')

In this case, when the instance of InhertedModel would be deleted, related objects will contain linked the instance of BaseModel and it's delete method will be called. Which collect instance of InhertedModel in related objects and call it's delete method. So we will have endless recursion.

This commit fixes it

ron8mcr commented 7 years ago

Travis checks failed with Django's master branch and seem like issue there, not in commits