search

pinax / pinax-notifications

user notification management for the Django web framework
MIT License
752 stars 211 forks source link

make medium use a label as identifier #36

Open sherzberg opened 10 years ago

sherzberg commented 10 years ago

fixes #21 this commit uses the backends label from NOTIFICATION_BACKENDS setting for easier to rearrange backends

for upgrades, you may have to write a custom alter statement to turn integers into varchars and then change the labels in your NOTIFICATION_BACKENDS to the string equivalent of the order

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling b832c3fa92ce05db15d05e82b43e75abc0bf9b19 on sherzberg:medium_id-is-label into 6782099acf104803185172b046a2ae1ad4e4c3cd on pinax:master.

paltman commented 9 years ago

@sherzberg I actually like this change. Sorry for not merging it sooner.

paltman commented 9 years ago

@sherzberg i'll try to update it and get it merged but if you could do me a favor and rebase your branch to get it updated so that I can merge it through GitHub it might make things faster. Thanks.

sherzberg commented 9 years ago

@paltman cool! i rebased and had to fix a few conflicts. tests seem to pass locally on python 2.7 and django 1.7-1.8. I dont have python 3 setup on my home machine, so just waiting to see if the the travis build works out ok.

ossanna16 commented 8 years ago

@paltman Can this be merged?

psychok7 commented 7 years ago

@sherzberg i tested this PR with python3 and it works.. hope it gets merged sometime

psychok7 commented 7 years ago

@paltman @ossanna16 can this be merged?