Replacing CharField for IntegerField for NoticeSetting model.

pinax / pinax-notifications

user notification management for the Django web framework

MIT License

752 stars 211 forks source link

Replacing CharField for IntegerField for NoticeSetting model. #38

Closed bsnux closed 9 years ago

bsnux commented 10 years ago

Fixes #21

coveralls commented 10 years ago

Coverage remained the same when pulling bbfe4da064efe73f8305cb70ecb3ec05f47d1f32 on bsnux:issue-21 into 6782099acf104803185172b046a2ae1ad4e4c3cd on pinax:master.

coveralls commented 10 years ago

Coverage remained the same when pulling bbfe4da064efe73f8305cb70ecb3ec05f47d1f32 on bsnux:issue-21 into 6782099acf104803185172b046a2ae1ad4e4c3cd on pinax:master.

paltman commented 10 years ago

@bsnux can you update your branch against master and resolve any conflicts? I'd like to get this merged in.

bsnux commented 10 years ago

@paltman Done! :)

coveralls commented 10 years ago

Coverage remained the same when pulling ee106e24e1ba27458754550a2d4dc750832adc88 on bsnux:issue-21 into 51444fa4d62b10be13ad3c852c8a2d175b839dba on pinax:master.

johndevor commented 9 years ago

poke

paltman commented 9 years ago

I like the solution in #36 better.

paltman commented 9 years ago

But thanks for your work on this!