search

pinax / pinax-notifications

user notification management for the Django web framework
MIT License
752 stars 211 forks source link

Allow create notice settings for any model #44

Closed purple-sunrise closed 9 years ago

purple-sunrise commented 9 years ago

This fix allow to send notifications to people in any tables/models (in my case there are two tables: user and person). I don't want to create user account for any person, but I want send notifications to them.

paltman commented 9 years ago
  1. Notice settings are very much a user centric thing
  2. The latest thing pushed to this repo was support of extending the NoticeSetting model to add other attributes to scope the notifications.
  3. Your local copy is out of date (as indicated by the greyed out merge button)
paltman commented 9 years ago

What is the use case you are trying to support?

purple-sunrise commented 9 years ago

I have system with users and persons. Persons have emails. And I want to send notifications on this emails sometimes. But I don't want to create user instance for this persons.

paltman commented 9 years ago

Are Person and User related?

On Mar 4, 2015, at 8:22 AM, Olesya Borzdyko notifications@github.com wrote:

I have system with users and persons. Persons have emails. And I want to send notifications on this emails sometimes. But I don't want to create user instance for this persons.

— Reply to this email directly or view it on GitHub.

purple-sunrise commented 9 years ago

No.

paltman commented 9 years ago

Then I think pinax-notifications is the wrong app for what you want. One of the core features is for users to be able to control what and how they receive notifications that the system sends out.

On Mar 4, 2015, at 8:41 AM, Olesya Borzdyko notifications@github.com wrote:

No.

— Reply to this email directly or view it on GitHub.

purple-sunrise commented 9 years ago

If I send notification to person, it can't create NoticeSettings for Person's instance. But in case of using generic relations it works. Yes, this add some difficulty in admin interface, but also add flexibility.

paltman commented 9 years ago

If you want to fork pinax-notifications and go a different direction with it, you have my complete support and encouragement.

At this time, we will not be adding GFK support instead of a direct link to user instance.

On Mar 4, 2015, at 8:46 AM, Olesya Borzdyko notifications@github.com wrote:

If I send notification to person, it can't create NoticeSettings for Person's instance. But in case of using generic relations it works. Yes, this add some difficulty in admin interface, but also add flexibility.

— Reply to this email directly or view it on GitHub.