pinax / pinax-starter-projects

Pinax Starter Projects
MIT License
81 stars 39 forks source link

Use static templatetag to remove hardcoded paths #28

Closed tubaman closed 8 years ago

tubaman commented 8 years ago

These hardcoded paths cause issues. For example, if I want to host the site at a different root path instead of '/', I have to edit these.

I think I branched from the correct branch(zero). If I understand correctly, you are keeping all the base code for all the starter project on zero.

jtauber commented 8 years ago

These files are generated so there's no point editing them.

ossanna16 commented 8 years ago

@jtauber Can this PR be closed?

jtauber commented 8 years ago

Yep, I'll close it.

ossanna16 commented 8 years ago

Thank you @jtauber!

tubaman commented 8 years ago

Can we change the way they are generated to use the static template tag? Can someone point me to the script?

On Tue, Apr 19, 2016 at 01:00:43PM -0700, James Tauber wrote:

These files are generated so there's no point editing them.


You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/pinax/pinax-starter-projects/pull/28#issuecomment-212102581

jtauber commented 8 years ago

@paltman can you point @tubaman to where _scripts.html and _styles.html get generated?

@tubaman feel free to open a separate issue to track this.

paltman commented 8 years ago

https://github.com/pinax/pinax-starter-projects/blob/zero/gulpfile.js#L51

and

https://github.com/pinax/pinax-starter-projects/blob/zero/gulpfile.js#L56

Sent from my iPad

On Apr 25, 2016, at 8:34 AM, James Tauber notifications@github.com wrote:

@paltman can you point @tubaman to where _scripts.html and _styles.html get generated?

@tubaman feel free to open a separate issue to track this.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

tubaman commented 8 years ago

Ok, here's a new PR that uses the static template tag in the handlebars source: https://github.com/pinax/pinax-starter-projects/pull/30