search

pinax / pinax-stripe-light

a payments Django app for Stripe
MIT License
686 stars 285 forks source link

Don't try to charge a customer with no card #564

Closed heliodor closed 6 years ago

heliodor commented 6 years ago

Stripe throws an error because we try to make a charge without having a card. Because we don't have a card for this user yet, it doesn't make sense to charge them immediately.

What's this PR do?

Fixes an exception thrown by Stripe because we try to do something that doesn't make sense: charge a customer who doesn't have a card on file.

Any background context you want to provide?

What ticket or issue # does this fix?

Closes #563

Definition of Done (check if considered and/or addressed):

codecov[bot] commented 6 years ago

Codecov Report

Merging #564 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          33       33           
  Lines        1917     1917           
  Branches      175      175           
=======================================
  Hits         1902     1902           
  Misses          7        7           
  Partials        8        8
Flag Coverage Δ
#py27dj110 98.9% <100%> (ø) :arrow_up:
#py27dj111 98.9% <100%> (ø) :arrow_up:
#py27dj18 99.16% <100%> (ø) :arrow_up:
#py34dj110 98.9% <100%> (ø) :arrow_up:
#py34dj111 98.9% <100%> (ø) :arrow_up:
#py34dj18 99.16% <100%> (ø) :arrow_up:
#py34dj20 98.9% <100%> (ø) :arrow_up:
#py35dj110 98.9% <100%> (ø) :arrow_up:
#py35dj111 98.9% <100%> (ø) :arrow_up:
#py35dj18 99.16% <100%> (ø) :arrow_up:
#py35dj20 98.9% <100%> (ø) :arrow_up:
#py36dj111 98.9% <100%> (ø) :arrow_up:
#py36dj20 98.9% <100%> (ø) :arrow_up:
#py36dj20psql 98.9% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
pinax/stripe/management/commands/init_customers.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6dfccc...980a1a4. Read the comment docs.