pinax / pinax-stripe-light

a payments Django app for Stripe
MIT License
684 stars 285 forks source link

Remove unexisting name from plan data for Synchronizes a plan action #625

Open andressspinetti opened 5 years ago

andressspinetti commented 5 years ago

What's this PR do?

Remove name from dict used for synchronize a plan.

Any background context you want to provide?

Plan object does not come with name property and makes the plan signals to fail. More information in Stripe Docs: https://stripe.com/docs/api/plans#plan_object

What ticket or issue # does this fix?

Closes #[issue number]

Definition of Done (check if considered and/or addressed):

codecov[bot] commented 5 years ago

Codecov Report

Merging #625 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   99.21%   99.21%   +<.01%     
==========================================
  Files          33       33              
  Lines        1911     1913       +2     
  Branches      175      176       +1     
==========================================
+ Hits         1896     1898       +2     
  Misses          7        7              
  Partials        8        8
Flag Coverage Δ
#py27dj110 98.9% <100%> (ø) :arrow_up:
#py27dj111 98.9% <100%> (ø) :arrow_up:
#py27dj18 99.16% <100%> (ø) :arrow_up:
#py34dj110 98.9% <100%> (ø) :arrow_up:
#py34dj111 98.9% <100%> (ø) :arrow_up:
#py34dj18 99.16% <100%> (ø) :arrow_up:
#py34dj20 98.9% <100%> (ø) :arrow_up:
#py35dj110 98.9% <100%> (ø) :arrow_up:
#py35dj111 98.9% <100%> (ø) :arrow_up:
#py35dj18 99.16% <100%> (ø) :arrow_up:
#py35dj20 98.9% <100%> (ø) :arrow_up:
#py36dj111 98.9% <100%> (ø) :arrow_up:
#py36dj20 98.9% <100%> (ø) :arrow_up:
#py36dj20psql 98.9% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
pinax/stripe/actions/plans.py 100% <100%> (ø) :arrow_up:
pinax/stripe/models.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0005850...35d88f0. Read the comment docs.