search

pinax / pinax-teams

an app for Django sites that supports open, by invitation, and by application teams
MIT License
49 stars 36 forks source link

Remove django-reversion dependency #56

Open jacobwegner opened 7 years ago

jacobwegner commented 7 years ago

As #33 notes, there is a backwards-incompatible change to django-reversion that breaks semantic versioning.

Rather than pinning to a particular version or updating _pinaxteams to be compatible, I'm wondering if we instead just drop the django-reversion requirement.

If desired, membership changes could be tracked via signals and a library like _pinaxeventlog, but currently reversion might be a bit overkill for the intended use-case of pinax-teams.

paltman commented 6 years ago

Yes! Let's kill it.

grahamu commented 6 years ago

As mentioned in the "django-20" branch merge, I have kept django-reversion in this project for the initial Django v2.0 compatible release so existing users have a path forward.

Let's examine whether a dev can add django-reversion to pinax-teams models within their own project and remove django-reversion if that works.