search

pinax / pinax-theme-bootstrap

A theme for Pinax based on Twitter's Bootstrap
Other
268 stars 136 forks source link

rethink relationship between _account_bar in theme vs projects #106

Open jtauber opened 8 years ago

jtauber commented 8 years ago

At the moment, the theme contains an _account_bar appropriate to and assuming django-user-accounts is used. This is then zeroed out in starter projects that don't use django-user-accounts. The _account_bar seems to be then duplicated in the account project (we need to check if it's in fact exactly the same).

So Option 1 would be just make the _account_bar in PTB blank to remove the duplication.

Option 2 would be to rename the _account_bar in PTB to something else and a project that wants to use it includes that newly named template in their _account_bar

But then Patrick suggested Option 3 which I like more than Option 2: rather than have the extra level of indirection, just have the various starter projects either include PTB's _account_bar or not in their own site_base.html

jtauber commented 8 years ago

As I think Option 3 is better than 2 but has roughly the same approach, I think it's down to 1 and 3 which really just come down to: should the actual account_bar live in the template or the base account starter project?

jtauber commented 8 years ago

One thing to consider: some descendants of that account project may have richer _account_bars. How would they work?