python3 compatibility - Githubissues

pinax / symposion

a Django project for conference websites

BSD 3-Clause "New" or "Revised" License

299 stars 147 forks source link

python3 compatibility #100

Closed miurahr closed 9 years ago

miurahr commented 9 years ago

Things are suggested in python3 porting guide. https://docs.djangoproject.com/en/1.8/topics/python3/
1. adding from django.utils.encoding import python_2_unicode_compatible
2. __str__ instead of __unicode__ https://docs.djangoproject.com/en/1.8/topics/python3/#str-and-unicode-methods
3. Adding from __future__ import unicode_literals at the top of your Python modules https://docs.djangoproject.com/en/1.8/topics/python3/#unicode-literals
4. Removing the u prefix before unicode strings; https://docs.djangoproject.com/en/1.8/topics/python3/#unicode-literals
also closed #66

Signed-off-by: Hiroshi Miura miurahr@linux.com

uranusjr commented 9 years ago

There are dependency issues too. Namely django-timezones does not support Python 3, and will probably require significant work to port. And considering it had received virtually no updates since 2011 (only one license update in 2014)…

miurahr commented 9 years ago

Dropping django-timezones and using pytz would be better. https://docs.djangoproject.com/en/1.8/topics/i18n/timezones/

Could you put an individual issue for it? and welcome PR!

paltman commented 9 years ago

@miurahr this is great! thanks! since merging some of your other PRs, I can no longer merge this one. Could you update and repush your branch?

miurahr commented 9 years ago

rebased.

I'd like to add another PR for timezones .

uranusjr commented 9 years ago

@miurahr django-timezone is used to provide TimeZoneField in the Conference model. Should we drop it and implement our own model field? I usually use django-timezone-field myself, but it might be a good idea not depending too much on other projects, too.

miurahr commented 9 years ago

@uranusjr I've also reached mfogel/django-timezone-field that is forked version of djando-timezone after short research. mfogel/django-timezone-field is good for symposion because it focused to a form field and symposion used timezones for form widget.

Symposion has a meaning as an one of django showcase how to combine pinax apps and 3rd party projects to realize reusable core.

I'd like to bid :+1: to mfogel/django-timezone-field

uranusjr commented 9 years ago

@miurahr Cool. I’ll submit a PR later today. Do we need a migration for the model change?