search

pinballmap / pbm-android

Android Application for pinballmap.com
http://pinballmap.com
9 stars 4 forks source link

Each time you load location details, the past machine comments seem to duplicate #178

Closed RyanTG closed 6 years ago

RyanTG commented 6 years ago

Steps:

Result:

The machine comment will be duplicated.

scottwainstock commented 6 years ago

I'm having trouble duplicating this!

RyanTG commented 6 years ago

I'll install a fresh build and test again.

RyanTG commented 6 years ago

Damn, still doing it for me. I uninstalled and reinstalled it on my phone.

RyanTG commented 6 years ago

screenshot_20171213-093910

scottwainstock commented 6 years ago

https://github.com/scottwainstock/pbm-android/commit/8daf5007cf0882904b23b013a1b467e1b0e382df

scottwainstock commented 6 years ago

@RyanTG OK well how about now?

RyanTG commented 6 years ago

I'm still experiencing the issue. I have another android phone - I'll load the app onto it just to doublecheck that it's not specific to my device.

RyanTG commented 6 years ago

Still there on phone #2.

scottwainstock commented 6 years ago

@RyanTG Can you put some debug statements in LocationMachineEdit... the loadConditions method?

I'm curious to see what the size of "ArrayList conditions" is for a specific location/machine.

scottwainstock commented 6 years ago

@RyanTG Preferably a location/machine that has more than 5 comments on it.

RyanTG commented 6 years ago

Sure, I can try.

Uh, how do I spit out conditions.size in a debug statement? Log.d("com.pbm", "NUM COMMENTS", conditions.size()); doesn't work. I can try to figure it out... but this is new to me.

scottwainstock commented 6 years ago

Log.d("com.pbm", "NUM COMMENTS: " + Integer.toString(conditions.size()));

On Sun, Dec 17, 2017 at 8:40 PM, Ryan TG notifications@github.com wrote:

Sure, I can try.

Uh, how do I spit out conditions.size in a debug statement? Log.d("com.pbm", "NUM COMMENTS", conditions.size()); doesn't work. I can try to figure it out... but this is new to me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-android/issues/178#issuecomment-352324448, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LfC38OWkYKOYH2e1RbCSxlQqxFFSks5tBezSgaJpZM4Q_Rza .

RyanTG commented 6 years ago

This is a machine with 12 comments. Anything else I can do to make this more useful?

12-17 20:45:56.924 31502-31502/com.pbm D/com.pbm: location Machine edit resume
12-17 20:45:56.928 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185]
12-17 20:45:56.928 31502-31502/com.pbm D/com.pbm: NUM COMMENTS: 12
12-17 20:45:56.934 31502-31502/com.pbm D/com.pbm: LOAD MACHINE CONDITIONS
12-17 20:45:56.934 31502-31502/com.pbm D/com.pbm: msx edit resume
12-17 20:45:56.936 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185]
12-17 20:45:57.080 31502-31502/com.pbm D/com.pbm.location: PBM onConnected
12-17 20:46:05.830 31502-31502/com.pbm D/com.pbm.location: PBM onConnected
12-17 20:46:08.268 31502-31502/com.pbm D/com.pbm: ENABLING SPINNER
12-17 20:46:08.297 31502-31502/com.pbm D/com.pbm: DISABLING SPINNER
12-17 20:46:08.419 31502-31502/com.pbm D/com.pbm.location: PBM onConnected
12-17 20:46:09.760 31502-31502/com.pbm D/com.pbm: ENABLING SPINNER
12-17 20:46:09.953 31502-32005/com.pbm D/com.pbm: https://pinballmapstaging.herokuapp.com/api/v1/region/la/locations/4653.json?user_email=scott.wainstock@gmail.com;user_token=NCkxWks7jyeuidUrEMJx
12-17 20:46:10.271 31502-31502/com.pbm D/com.pbm: DISABLING SPINNER
12-17 20:46:10.286 31502-31502/com.pbm I/Choreographer: Skipped 33 frames!  The application may be doing too much work on its main thread.
12-17 20:46:10.362 31502-31502/com.pbm D/com.pbm.location: PBM onConnected
12-17 20:46:10.380 31502-31502/com.pbm W/IInputConnectionWrapper: finishComposingText on inactive InputConnection
12-17 20:46:10.409 31502-31549/com.pbm D/OpenGLRenderer: endAllActiveAnimators on 0x61d40d00 (ListView) with handle 0xaf8d41d0
12-17 20:46:11.970 31502-31502/com.pbm D/com.pbm: location Machine edit resume
12-17 20:46:11.974 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185]
12-17 20:46:11.974 31502-31502/com.pbm D/com.pbm: NUM COMMENTS: 24
12-17 20:46:11.979 31502-31502/com.pbm D/com.pbm: LOAD MACHINE CONDITIONS
12-17 20:46:11.979 31502-31502/com.pbm D/com.pbm: msx edit resume
12-17 20:46:11.981 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185]
12-17 20:46:12.197 31502-31502/com.pbm D/com.pbm.location: PBM onConnected
scottwainstock commented 6 years ago

What's the location/machine name?

On Sun, Dec 17, 2017 at 8:49 PM, Ryan TG notifications@github.com wrote:

This is a machine with 12 comments. Anything else I can do to make this more useful?

12-17 20:45:56.924 31502-31502/com.pbm D/com.pbm: location Machine edit resume 12-17 20:45:56.928 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185] 12-17 20:45:56.928 31502-31502/com.pbm D/com.pbm: NUM COMMENTS: 12 12-17 20:45:56.934 31502-31502/com.pbm D/com.pbm: LOAD MACHINE CONDITIONS 12-17 20:45:56.934 31502-31502/com.pbm D/com.pbm: msx edit resume 12-17 20:45:56.936 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185] 12-17 20:45:57.080 31502-31502/com.pbm D/com.pbm.location: PBM onConnected 12-17 20:46:05.830 31502-31502/com.pbm D/com.pbm.location: PBM onConnected 12-17 20:46:08.268 31502-31502/com.pbm D/com.pbm: ENABLING SPINNER 12-17 20:46:08.297 31502-31502/com.pbm D/com.pbm: DISABLING SPINNER 12-17 20:46:08.419 31502-31502/com.pbm D/com.pbm.location: PBM onConnected 12-17 20:46:09.760 31502-31502/com.pbm D/com.pbm: ENABLING SPINNER 12-17 20:46:09.953 31502-32005/com.pbm D/com.pbm: https://pinballmapstaging.herokuapp.com/api/v1/region/la/locations/4653.json?user_email=scott.wainstock@gmail.com;user_token=NCkxWks7jyeuidUrEMJx 12-17 https://pinballmapstaging.herokuapp.com/api/v1/region/la/locations/4653.json?user_email=scott.wainstock@gmail.com;user_token=NCkxWks7jyeuidUrEMJx12-17 20:46:10.271 31502-31502/com.pbm D/com.pbm: DISABLING SPINNER 12-17 20:46:10.286 31502-31502/com.pbm I/Choreographer: Skipped 33 frames! The application may be doing too much work on its main thread. 12-17 20:46:10.362 31502-31502/com.pbm D/com.pbm.location: PBM onConnected 12-17 20:46:10.380 31502-31502/com.pbm W/IInputConnectionWrapper: finishComposingText on inactive InputConnection 12-17 20:46:10.409 31502-31549/com.pbm D/OpenGLRenderer: endAllActiveAnimators on 0x61d40d00 (ListView) with handle 0xaf8d41d0 12-17 20:46:11.970 31502-31502/com.pbm D/com.pbm: location Machine edit resume 12-17 20:46:11.974 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185] 12-17 20:46:11.974 31502-31502/com.pbm D/com.pbm: NUM COMMENTS: 24 12-17 20:46:11.979 31502-31502/com.pbm D/com.pbm: LOAD MACHINE CONDITIONS 12-17 20:46:11.979 31502-31502/com.pbm D/com.pbm: msx edit resume 12-17 20:46:11.981 31502-31502/com.pbm D/com.pbm: timezone is libcore.util.ZoneInfo[id="America/Los_Angeles",mRawOffset=-28800000,mEarliestRawOffset=-28800000,mUseDst=true,mDstSavings=3600000,transitions=185] 12-17 20:46:12.197 31502-31502/com.pbm D/com.pbm.location: PBM onConnected

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-android/issues/178#issuecomment-352325348, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LVNA9e_rFKhp6rC-ixmO4QXtzoqEks5tBe7YgaJpZM4Q_Rza .

RyanTG commented 6 years ago

Region: Los Angeles Location: 3.99 Pizza Company Machine: Attack from Mars

RyanTG commented 6 years ago

Also, I can see this issue when I use the emulator. I'm using Nexus_5X_API25_x86

scottwainstock commented 6 years ago

Oh nice, thanks.

On Sun, Dec 17, 2017 at 8:57 PM, Ryan TG notifications@github.com wrote:

Also, I can see this issue when I use the emulator. I'm using Nexus_5X_API25_x86

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-android/issues/178#issuecomment-352326191, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LcZYwljYzqmxDKb-Gpq1Y0yphqFWks5tBfDGgaJpZM4Q_Rza .

scottwainstock commented 6 years ago

haha, I still can't reproduce it... same everything.

BUT... I am seeing the number of conditions jump on the backend, even if the front-end doesn't reflect this. So, I think I can fix the backend and that'll fix your front-end.

On Sun, Dec 17, 2017 at 9:03 PM, Scott Wainstock scott.wainstock@gmail.com wrote:

Oh nice, thanks.

On Sun, Dec 17, 2017 at 8:57 PM, Ryan TG notifications@github.com wrote:

Also, I can see this issue when I use the emulator. I'm using Nexus_5X_API25_x86

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-android/issues/178#issuecomment-352326191, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LcZYwljYzqmxDKb-Gpq1Y0yphqFWks5tBfDGgaJpZM4Q_Rza .

scottwainstock commented 6 years ago

@RyanTG OK well maybe this fixed it. https://github.com/scottwainstock/pbm-android/commit/32370174592868e22b9656e9af0c567d81e13996

RyanTG commented 6 years ago

Fixed!