Recently Added - crashing if visited before rest of data loads

[RyanTG]

From what I can tell:

• open app
• immediately visit recently added section

Result: crash.

If you wait and load the rest of the data (like if you visit the lookup by location section and wait for the data to load) before visiting recently added, then it doesn't crash. I replicated out a couple times.

[scottwainstock]

@RyanTG Crash log would be helpful, I'm not able to replicate it on hardware.

[scottwainstock]

@RyanTG Would you mind doing this again, but having it start FROM Android Studio? It'll ask you to replace the app on your phone... just do that. Notice how the NullPointerException part has "Unknown Source" and no line numbers and all that? It's proguard obfuscating the logs. If you run it all from Android Studio, we'll get line numbers / etc.

[RyanTG]

Replaced log and pasted it here: https://gist.github.com/RyanTG/2d2635418e2b098c18648495bc441586

[scottwainstock]

@RyanTG How about this?

https://github.com/scottwainstock/pbm-android/commit/3633f63851f7e6b2238258f9343fe9eff62402cf

[RyanTG]

Did not crash. Took quite a while to load, though. See gist https://gist.github.com/RyanTG/18f99ebff499e30cbd8d45d795c920b7

[scottwainstock]

Yeah it has to get detail info on 20 locations/machines... that's part of the "lazy loading" thing. We could work on caching that so it doesn't do the load every single time I guess.

On Wed, Jan 3, 2018 at 9:21 PM, Ryan TG notifications@github.com wrote:

Did not crash. Took quite a while to load, though. See gist https://gist.github.com/RyanTG/18f99ebff499e30cbd8d45d795c920b7

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-android/issues/183#issuecomment-355201527, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LVf7OIloGACi6_rB__T6pl0qoU4hks5tHF_PgaJpZM4RSglf .

[RyanTG]

Well, since that's a separate task, maybe this is good to ship then. Should I test anything else?

[scottwainstock]

@RyanTG I don't think so.. but given our issue last week, I put a signed build here: scottwainstock.com/app-release.apk

I'm checking it on my Nexus... maybe check it real quick on your phone?

[RyanTG]

Checking

[RyanTG]

Crap! The issue also exists on Recent High Scores.

I should have realized that earlier.

[scottwainstock]

https://github.com/scottwainstock/pbm-android/commit/8d7d3d81b5c4c0fc2da16f10890e77b738efd760

[scottwainstock]

@RyanTG I'm going to bed... but if you like that, I can put a build out tomorrow after work.

[RyanTG]

Seems good!