Machine info

[RyanTG]

When you're looking at the machines that are listed under a location.

Currently, when you click on a machine name, it shows you the condition comment, and that's it.

What about:

Machines Condition (and it would be nice to get rid of the fixed-height box that's currently there) High Scores Add Your Score Other Locations (a link that when clicked shows which other locations have that machine)

I could try to mock up some screenshots for how I'm envisioning this.

[scottwainstock]

Gimme those screenshots.

[RyanTG]

I'll work on them.

[RyanTG]

Note to self: include pintips link, too.

[RyanTG]

Very rough screenshot (sorry, I suck at GIMP). Let me know if you have any questions. I think it would be sweet if the remove button at the bottom was ALWAYS visible on the page, even if the contents of the page have to scroll. And the high score list should look similar to the comments list. Also, I don't think we need to include Rank on the scores. But it would be cool if they are in ascending order and only the top 5 show up.

[RyanTG]

the pintips link is http://pintips.net/pinmap/machine/{machine_id} OR http://pintips.net/pinmap/group/{group_id} If that machine is part of a group.

[scottwainstock]

pintips and other locations: 44430fd1b859393285221ae117ce08298fddd915

[scottwainstock]

only show last 5 conditions: 255c9ea405b3d8f4ef36d85c4d022710814baed1

[scottwainstock]

@RyanTG Can you take a look at this when you get a second? I need to add the high scores, but I think we ran out of real estate.

[RyanTG]

Yes, will do tomorrow. It's ok if the page scrolls, right?

[scottwainstock]

Oh yeah, uhhh... somehow forgot that pages can scroll! I'll make add the scores and make it scroll (with a fixed/floating remove machine button).

On Sun, Jul 24, 2016 at 10:12 PM, RyanTG notifications@github.com wrote:

Yes, will do tomorrow. It's ok if the page scrolls, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-android/issues/22#issuecomment-234842267, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LYQkYEJPo_Au3X6d4aaWnod0sr7Yks5qZEW_gaJpZM4CdwaP .

[scottwainstock]

username in api feed: https://github.com/scottwainstock/pbm/commit/597ba5a04c0fad33e8b395d9ba2443fe9b1d52d1

[scottwainstock]

Everything except the ability to add high scores: 62db8f0b0726e719c55496ed8db82d2564484fda

[scottwainstock]

Return msx info when one is created via the api: https://github.com/scottwainstock/pbm/commit/88deb58ea29eb32fc0013f9c56c82a272e0337a2

[scottwainstock]

enter scores: 4a87b92f734025094fc811d7e8ec703a896848bc

[scottwainstock]

@RyanTG OK, I think this is done now. We need some styling on the enter condition and enter score pages, I think... pretty basic there right now. Also the LocationMachineEdit screen is all over the place. Some links are buttons, others are clickable text. How do we want to normalize that stuff? All buttons?

[RyanTG]

Not sure about all buttons. It might look weird to have so many buttons. But you have a point that at least it will be uniform. Right now, though, I think the clickable text includes words that make it somewhat clear that it should be clicked. Well anyway, tomorrow I'll try to style the page so it looks better. Thanks!

[RyanTG]

Should I make a new issue for this? The location detail view has some weird scrolling behavior. 1) there's an empty space (like 40dp) at the bottom, and 2) the entire page isn't scrolling, only the machines are.

[scottwainstock]

@RyanTG Y, please.