pinballmap / pbm-ios

PBM iOS App
MIT License
10 stars 6 forks source link

Past conditions are not in sequential order #112

Closed RyanTG closed 7 years ago

RyanTG commented 7 years ago

I can't tell what order they're in. But there are ones from Dec in the middle of ones from today. And the second most recent one is at the bottom of the list.

iPad and iPhone are showing a different order from each other on the same machine.

RyanTG commented 7 years ago

And after you restart the app, sometimes the most recent comment also shows up as a past comment (so it's on there twice)

scottwainstock commented 7 years ago

But sometimes, after you restart the app, it doesn't?

On Mon, Jan 30, 2017 at 8:28 PM, RyanTG notifications@github.com wrote:

And after you restart the app, sometimes the most recent comment also shows up as a past comment (so it's on there twice)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scottwainstock/pbm-ios/issues/112#issuecomment-276272338, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK-LePia2RONJLlPsdXxlz2TxBu3dUbks5rXrh7gaJpZM4LyOPx .

RyanTG commented 7 years ago

I guess it always does show it twice. I just didn't notice it at first because my comments were too generic and I was losing track of when I wrote them. So, always.

Also, I just discovered that you don't have to restart the app. Instead, you can do a pull down to refresh the data. Oops, that comment was referring to the issue of comments disappearing.

scottwainstock commented 7 years ago

@RyanTG Can you point me to a location/region where you're seeing this?

scottwainstock commented 7 years ago

@RyanTG By "this" I mean random ordering of past comments. I think I have all this fixed, I just need to know where to verify it.

RyanTG commented 7 years ago

Los Angeles. 3.99 Pizza Company. Look at the comments on attack from Mars.

RyanTG commented 7 years ago

On that machine, Comment 1 - 3 were made sequentially. And you can also look at the dates of the other comments.

scottwainstock commented 7 years ago

I think this will do it: https://github.com/scottwainstock/pbm-ios/commit/ffb38860ba855f706739999d7c043d73f178e050