Incorrect number of machines listed in region info

pinballmap / pbm-ios

PBM iOS App

MIT License

10 stars 6 forks source link

Incorrect number of machines listed in region info #124

Closed RyanTG closed 7 years ago

RyanTG commented 7 years ago

EDIT: The bug: the region tab lists an incorrect number of machines for the region. It seems to be a lower number in each case.

See screenshot of live app. Compare app to stats on website (since website is definitely correct).

RyanTG commented 7 years ago

Yes, the iOS app is recording the wrong number of machines on the dev app (and live app). On the staging website for Portland, it's listing "255 locations and 367 machines." And the app is listing "255 locations and 119 machines." (note the android doesn't list this info)

The listing for Los Angeles is wrong, too, so I'm going to assume they're all wrong.

I'm labeling this as a bug, and changing the issue title. Not assigning auth.

scottwainstock commented 7 years ago

@RyanTG Dug into this... the machine number is the count of UNIQUE machines. Just kind of confusingly worded.

Change the wording? Add the total number of machines? Remove the unique machine count?

RyanTG commented 7 years ago

Change the wording? No Add the total number of machines? Yes Remove the unique machine count? Yes

That's what I think. Then it will match the website. Who cares about unique.

scottwainstock commented 7 years ago

https://github.com/scottwainstock/pbm-ios/commit/0c7f551b29fcf39155435e255fcdf436224d3d5d