search

pinballmap / pbm-react

PBM React Native: iOS & Android Apps
https://pinballmap.com/app
GNU General Public License v3.0
33 stars 9 forks source link

Include build number in header #504

Closed RyanTG closed 1 year ago

RyanTG commented 1 year ago

Problem: when people submit locations and stuff (basically, when some emails are sent) we like to include user agent info; for iOS app users, the user agent automatically includes the app build number; but for Android users it does not.

Goal: pass the build number, so we can see it!

This would perhaps entail adding the build number to the header https://github.com/pinballmap/pbm-react/blob/master/app/config/request.js#L8

And then including that request here https://github.com/pinballmap/pbm/blob/master/app/controllers/application_controller.rb#L97

and request.headers["BUILD-VERSION"]

RyanTG commented 1 year ago

https://github.com/pinballmap/pbm-react/commit/43f8f4babfe856cb14b7ba5174ae2b607538a81b

Instead of Build Number, I included app version number.