pinballmap / pbm-react

PBM React Native: iOS & Android Apps
https://pinballmap.com/app
GNU General Public License v3.0
33 stars 9 forks source link

Replace ipdb_link with ipdb_id #505

Closed RyanTG closed 1 year ago

RyanTG commented 1 year ago

Both ipdb_link and ipdb_id come from the machines endpoint. From a database perspective, those two fields are basically interchangeable - meaning we don't need both of them. The hyperlink to ipdb can be easily constructed using only the ipdb_id. Having a separate field with the full hyperlink is unnecessary.

I have no plans to remove ipdb_link from the database - though doing so would slightly increase the requests! But just in case we remove it at some point, let's just replace ipdb_link with ipdb_id in our code. I'm going to do the same on the website.

RyanTG commented 1 year ago

https://github.com/pinballmap/pbm-react/commit/fa2849a58404458a429873ee3abc95a7cbe5dcfe