Handling of app store reviewers

pinballmap / pbm-react

PBM React Native: iOS & Android Apps

https://pinballmap.com/app

GNU General Public License v3.0

33 stars 9 forks source link

Handling of app store reviewers #527

Closed RyanTG closed 8 months ago

RyanTG commented 9 months ago

Issue:

Both app stores require us to provide user credentials so they can test all functionality. The problem is that they are testing functionality on production data.

Possible solutions:

In the app, detect if the user is X and if so, show them the staging API_URL instead of production. It almost seems like we should add a field to the users table for "tester = true" and use that, given that we probably don't want to hard code a specific user into the app.
In the API, do some sort of thing that I'm too lazy to type up right now. Might edit later.

bpoore commented 8 months ago

branch Note, to the .env we need: STAGING_API_URL STORE_TESTERS=[username, username]

bpoore commented 8 months ago

We may need some additional work to ensure when we swap from prod -> api that the locations rendered exist in staging (i.e. trigger a re-render of the map locations). I didn't run into any issues testing, but could see that being a potential issue.

bpoore commented 8 months ago

Actually, if they login when first prompted, it shouldn't be an issue. The potential issue is if they skip logging in initially and have the map initially rendered with prod data.

RyanTG commented 8 months ago

No idea what they do, but I think there's a good chance they login when first prompted given that they are starting with a fresh install. I think we just assume this, and if they reject the review then we can go from there.