Expand localization of distance/user preference across the app

pinballmap / pbm-react

PBM React Native: iOS & Android Apps

https://pinballmap.com/app

GNU General Public License v3.0

33 stars 9 forks source link

Expand localization of distance/user preference across the app #535

Open ErikGraciosa opened 6 months ago

ErikGraciosa commented 6 months ago

Found that the events page text when no events were returned was not toggling km/mi but the buttons to change distance do toggle km/mi. Looking across the app, the activities page does not toggle km/mi.

ErikGraciosa commented 6 months ago

Added a draft PR. https://github.com/pinballmap/pbm-react/pull/536 The distances I added in km are rounding to the nearest nice looking number. It didn't look like the API used a unit currently so the distance change is only presentational and the actual distance is still miles. Probably could refactor this some to reduce the repetition of values but curious if the change is desired or not before getting too far into it.

RyanTG commented 6 months ago

Yeah, I think we just didn't bother with adjusting the distance unit in this case because it didn't seem terribly important. Beth can probably refresh my memory, though.

So I guess the options are:

Keep as is
Show km or mi but don't actually change the distance value used in the api requests
Show km or mi but change the distance value in the api requests

ErikGraciosa commented 6 months ago

I would also add

Fix events page to match units.

RyanTG commented 4 months ago

This PR is open but incomplete. Are you planning to complete it?

ErikGraciosa commented 4 months ago

Yes I can promote this from draft. I'll be able to submit in the next few days. I haven't loaded the app locally in a while, I'll likely need a new build. Is there a place to get that from? @RyanTG

RyanTG commented 4 months ago

I'll make new dev builds. Can you shoot an email to admin@pinballmap and then I'll send you the link to it?

ErikGraciosa commented 4 months ago

sent.