search

pinballmap / pbm-react

PBM React Native: iOS & Android Apps
https://pinballmap.com/app
GNU General Public License v3.0
33 stars 9 forks source link

On the addMachine modal in findMachine, include a backglass image if available #542

Closed RyanTG closed 5 months ago

RyanTG commented 5 months ago

To help users figure out if the version they're adding is the correct version, include a backglass image (if available) on that "confirm adding a machine" modal.

RyanTG commented 5 months ago

https://github.com/pinballmap/pbm-react/commit/b556e089213f6fc3662c6cfc4eca51685b42188a

Seems good. I see a jitter sometimes as the image loads. Not sure if I did something wrong there.

Had to make the modal vertical aligned to the top, rather than center, and then I just shoved in some top margin.

bpoore commented 5 months ago

Looks awesome- combined the uses into a single component. Helps clear some stuff out of FineMachine and MachineDetails