search

pinballmap / pbm-react

PBM React Native: iOS & Android Apps
https://pinballmap.com/app
GNU General Public License v3.0
34 stars 9 forks source link

(Display `Added:` date for new machines in LocationDetails view #546

Closed unitof closed 7 months ago

unitof commented 7 months ago

Note that I have not tested or build this at all! Just working blind in the code here.

I'm a mostly a web developer but eager to get up to speed locally building/testing if needed.

Let me know if this breaks anything as-is or requires any other changes/tests and I can start learning!

Fixes #545

unitof commented 7 months ago

(PS: Jacob Ford here from the Patreon)

unitof commented 7 months ago

Oh, do you think a different icon would be appropriate for newly added machines? (Any place I can see the available icons?)

RyanTG commented 7 months ago

Thanks! Will test it out.

Icons are here: https://icons.expo.fyi/Index

Unsure if a new one is necessary in this case...

unitof commented 7 months ago

Yeah, all I can think of is an "earlier" clock time, but that might be too clever by 3 hours.

RyanTG commented 7 months ago

Good idea. I changed it to three. Three and four - I thought those two times looked best.

I had to put the condition outside of the view, because of some jsx rule.

Thanks!