search

pinballmap / pbm

Pinball Map
https://pinballmap.com
GNU General Public License v3.0
110 stars 25 forks source link

List removed machines for location #1516

Closed RyanTG closed 1 year ago

RyanTG commented 1 year ago

As a kind of location history. I was thinking we could use the user_submissions table for this. In my tests, I added a submission_type filter. So like http://localhost:3000/api/v1/user_submissions/location.json?id=16910;submission_type=remove_machine shows the removed machines.

I'll work on the website. I imagine it will be similar to the Location History section, but just filtered for removed machines.

Stretch idea that I'll probably not do: use the machine added submission and machine removed submission to create a span of time and show when the machine was there.

RyanTG commented 1 year ago

https://github.com/pinballmap/pbm/commit/44b5655dd2918a68930a7ac67cb004a91d0f7c1b https://github.com/pinballmap/pbm/commit/c66f062eec5d3b34139122a5aca7276f84e4d698

Could probably use tests (along with tests for showing recent activity).