pinchbv / floor

The typesafe, reactive, and lightweight SQLite abstraction for your Flutter applications
https://pinchbv.github.io/floor/
Apache License 2.0
967 stars 191 forks source link

Add TaskStatus.open as status when creating a new task #764

Open SEGVeenstra opened 1 year ago

SEGVeenstra commented 1 year ago

Fixes #763

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.92%. Comparing base (a618e06) to head (808f14d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #764 +/- ## ======================================== Coverage 91.92% 91.92% ======================================== Files 11 11 Lines 223 223 ======================================== Hits 205 205 Misses 18 18 ``` | [Flag](https://app.codecov.io/gh/pinchbv/floor/pull/764/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pinchbv) | Coverage Δ | | |---|---|---| | [floor](https://app.codecov.io/gh/pinchbv/floor/pull/764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pinchbv) | `91.92% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pinchbv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stephanmantel commented 1 year ago

Even though I like most of the formatting changes, it got me thinking is there an agreed upon style guide for this project? And if not, should there be?

SEGVeenstra commented 1 year ago

I had to add an analyzer exception to make the tests pass. This happens to resolve #742 😄