pinchbv / floor

The typesafe, reactive, and lightweight SQLite abstraction for your Flutter applications
https://pinchbv.github.io/floor/
Apache License 2.0
947 stars 190 forks source link

Analyzer issues #815

Closed dkaera closed 5 months ago

dkaera commented 5 months ago

I'm submitting a PR on GitHub that contains crucial updates for addressing code analysis issues. It also introduces analysis options to the example project, which flags a warning when accessing the private _$...DatabaseBuilder. To resolve this, I've added an interface and accompanying tests to cover these updates. These changes are vital for fixing the problems that are currently hindering web integration support. I've tested the PR with my adjustments, and everything is working well. Merging this PR will unblock the web_support PR #730

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.92%. Comparing base (a618e06) to head (f2a954f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #815 +/- ## ======================================== Coverage 91.92% 91.92% ======================================== Files 11 11 Lines 223 223 ======================================== Hits 205 205 Misses 18 18 ``` | [Flag](https://app.codecov.io/gh/pinchbv/floor/pull/815/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pinchbv) | Coverage Δ | | |---|---|---| | [floor](https://app.codecov.io/gh/pinchbv/floor/pull/815/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pinchbv) | `91.92% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pinchbv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.