pincushionman / cfg-loader

Automatically exported from code.google.com/p/cfg-loader
0 stars 0 forks source link

Sorting method doesn't work with long title name #45

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. in config.txt:
db_language = JA
translation = JA
load_unifont = 1

What is the expected output? What do you see instead?
some long title name's games exists in the upper part of the list in the
irregular order.

What version of the loader are you using?
v55

What is your System Menu version (e.g. 4.2u)?
4.2J

What is your media type (HDD, USB Flash, SD/SDHC)?
HDD

How is your media formatted (wbfs, fat32, ntfs)?
ntfs

Which cios are you using and which version (222, 249v??)?
249v19

Please provide any additional information below.
in Japanese games, there are some looong title name.
and a Japanese character consumes 3 bytes with UTF-8.
please please fix the "#define TITLE_MAX 64" in cfg.c to 160 or more.

Original issue reported on code.google.com by masamo...@gmail.com on 13 Mar 2010 at 4:24

GoogleCodeExporter commented 9 years ago
I think in 2D mode, one line of menu item can not display 160 characters, or 53 
CJK characters. If extend TITLE_MAX, cut off long UTF-8 title name correctly 
also needed 
in 2D mode.

Original comment by noboo...@gmail.com on 13 Mar 2010 at 10:15

GoogleCodeExporter commented 9 years ago
I already tried modify TITLE_MAX to 160 and compile it.
one line of menu item displays already correctly with cutting off with putting 
"..."
characters at last of line. and everything seem OK.

Original comment by masamo...@gmail.com on 14 Mar 2010 at 2:40

GoogleCodeExporter commented 9 years ago
Can you tell me an example game with such a long title?
btw, most themes use a console with a width of around 40 characters, a Japanese 
letter 
takes up 2 characters, so i would say that a title with only 20 Japanese 
letters can be 
displayed, if each takes 3 bytes that is 60 bytes, still less than the current 
limit of 
64. Or am i missing something?

Original comment by ogg...@gmail.com on 14 Mar 2010 at 9:51

GoogleCodeExporter commented 9 years ago
these are example of long title.
SMUJAF, RZ8JG9, RGOJJ9, RGPJAF, RFFJGD, DCHJAF, R5XJ13, R43J13, RFCJGD, RZ5JG9,
ROUJAF, R5WJA4, RIUJAF, RGEJJ9, RYAJDA, RKJJ0Q, RFSJ8P, RZ4JG9, RD6J8N, RH7J8P,
SISJ0Q, RKNJ2N, RILJ18, STKJ08, RKAJMS, RS9J8P, RD4JA4, RDDJA4, RJRJA4, RHRJ99,
RC4JD9, DHHJ8J, RMBJ01, RDUJDQ, RN3J78, SBBJ18, SMTJ18, RK6J18, REKJ2N, RSMJ8P,
RW3J4Q, RZ2JG9, R32J01, R2QJC0, RDXJ18, RSZJES, SUMJC8, RYKJAF
yes, you are correct.
in this topic, I want to say about sorting function is incorrect with over 64 
bytes.
TITLE_MAX = 64:
  only 20 Japanese letters can be displayed at one line of menu.
  only 20 Japanese letters can be displayed (with buggy characters at tail) at before
game starting screen.
  displayed wrong order when sorting in alphabetical order.
TITLE_MAX = 160:
  only 20 Japanese letters can be displayed at one line of menu (same as above).
  full letters can be displayed at before game starting screen.
  displayed correct order when sorting in alphabetical order.
of course, it is more better idea that more 40 characters can be displayed on 
menu
like as USBL-GX.

Original comment by masamo...@gmail.com on 15 Mar 2010 at 1:36

GoogleCodeExporter commented 9 years ago
Can you please test this:
http://cfg-loader.googlecode.com/files/cfg56b_test45.dol
And let me know if sorting of long titles is now fixed?

Original comment by ogg...@gmail.com on 15 Mar 2010 at 7:19

GoogleCodeExporter commented 9 years ago
I tried it.
the sorting function working correctly now.

Original comment by masamo...@gmail.com on 16 Mar 2010 at 10:20

GoogleCodeExporter commented 9 years ago
Thanks.

Original comment by ogg...@gmail.com on 16 Mar 2010 at 6:33