pindell-matt / rust_bucket

Simple JSON key-value store implemented in Rust
Other
11 stars 6 forks source link

slight refactor to avoid so much serde work and more tests #23

Closed selfup closed 8 years ago

selfup commented 8 years ago

Just a slight refactor to avoid so much serde work

selfup commented 8 years ago

Travis seems to be failing to compile our repo with nightly? Hmm...

selfup commented 8 years ago

Tried to build on the new nightly (2016-06-20) that Travis pulled, and it failed locally. Went back to 2016-06-09 and it works fine. Seems that Serde is always a week behind.

Sean Griffin mentioned this with Diesel as well. He recommends using the previous weeks nightly.

selfup commented 8 years ago

Ok awesome. Travis built on 06-10. Going to upgrade to 06-15

Built on 06-15. Back to normal. Will use VM in the future to test nightlies.

Wasn't sure how to specify versions on Travis.

Now I know haha

selfup commented 8 years ago

@cite-reader @pindell-matt

Ok so you can indeed specify the nightly version with Travis CI, I'll use a local VM to test future versions, and then tell Travis which nightly to pull. Will also need to update Documentation often, but that's fine.

PR is ready to be merged

selfup commented 8 years ago

Seems pretty fast to me!

screenshot from 2016-06-23 00 19 33

selfup commented 8 years ago

The slowest operation (out of three benchmarks) takes:

0.06634 milliseconds

OR

0.00006634 seconds

The fastest operation (out of three benchmarks) takes:

0.00138 milliseconds

OR

0.00000138 seconds

On Linux

pindell-matt commented 8 years ago

Looks good to me!