pindell-matt / rust_bucket

Simple JSON key-value store implemented in Rust
Other
11 stars 6 forks source link

Add create_empty_table function #33

Closed pindell-matt closed 8 years ago

pindell-matt commented 8 years ago

Basic function to create an empty table: create_empty_table Tested with it_can_create_and_drop_an_empty_table

cite-reader commented 8 years ago

I'd expect the serialization of a Data object that contains an empty map. Append, read, etc. would then work as expected instead of failing with desrialization errors. On Jul 4, 2016 12:18, "Matt Pindell" notifications@github.com wrote:

Basic function to create an empty table: create_empty_table

Tested with it_can_create_and_drop_an_empty_table

You can view, comment on, or merge this pull request online at:

https://github.com/pindell-matt/rust_bucket/pull/33 Commit Summary

  • Add create_empty_table function
  • Add test for creating and dropping empty table

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pindell-matt/rust_bucket/pull/33, or mute the thread https://github.com/notifications/unsubscribe/AEAKexL8jPbnezAwRiFel4UHZFTzY7bIks5qSVyUgaJpZM4JEnLO .

pindell-matt commented 8 years ago

Totally makes sense - on it.

selfup commented 8 years ago

Just realized: Since this will have no records yet, next_id should be "0"

pindell-matt commented 8 years ago

Good catch, changed index to "0"

selfup commented 8 years ago

LGTM!