Closed cite-reader closed 8 years ago
Thanks for the nice PR!
Really digging this so far. Thanks for cleaning things up!
Gonna wait for @pindell-matt to review this as well
I get 274,867 ns/iter (+/- 25,608)
on Windows. Let me check on OSX
Which rust nightly are you running? My build fails on OSX with rustup override add nightly-2016-05-30
I keep failing on aster.
I uninstalled rust. This problem occurs on this repo now for OSX.
Reinstalling using rustup.
Will poke around
Ok got it running on: rustc 1.11.0-nightly (5c2a5d449 2016-06-11)
Woowoo
208,157 ns/iter (+/- 62,297) on OSX 2015 MBP i5 8GB RAM
What kind of rig are you running?
My Windows rig has an i5 6600k at 4.3Ghz. Just wondering how you are getting such amazing performance per iter
I'll run this on Ubuntu 14.04 and Fedora 23 on a three year old ASUS laptop with an i7.
Darwin already ran faster on the iters compared to W10. I am sure Linux will have better results
Sorry for the delay - this all looks great, merging now.
I have a recent Thinkpad with an i7 processor... and no spinning disks whatsoever. The solid-state hard drive probably has a bit of an effect on filesystem performance.
Improved errors, tidied up features being asked for, taking string slices where possible.
Pulled the benchmark into its own function, and hooked the rustc-provided benchmark infrastructure. Run
cargo bench
to see that; I get 18,968 ns/iter, what do you get?