search

pindell-matt / rust_bucket

Simple JSON key-value store implemented in Rust
Other
11 stars 6 forks source link

Housekeeping #6

Closed cite-reader closed 8 years ago

cite-reader commented 8 years ago

Improved errors, tidied up features being asked for, taking string slices where possible.

Pulled the benchmark into its own function, and hooked the rustc-provided benchmark infrastructure. Run cargo bench to see that; I get 18,968 ns/iter, what do you get?

selfup commented 8 years ago

Thanks for the nice PR!

Really digging this so far. Thanks for cleaning things up!

Gonna wait for @pindell-matt to review this as well

selfup commented 8 years ago

I get 274,867 ns/iter (+/- 25,608) on Windows. Let me check on OSX

selfup commented 8 years ago

Which rust nightly are you running? My build fails on OSX with rustup override add nightly-2016-05-30

selfup commented 8 years ago

I keep failing on aster.

I uninstalled rust. This problem occurs on this repo now for OSX.

Reinstalling using rustup.

Will poke around

selfup commented 8 years ago

Ok got it running on: rustc 1.11.0-nightly (5c2a5d449 2016-06-11)

Woowoo

selfup commented 8 years ago

208,157 ns/iter (+/- 62,297) on OSX 2015 MBP i5 8GB RAM

What kind of rig are you running?

My Windows rig has an i5 6600k at 4.3Ghz. Just wondering how you are getting such amazing performance per iter

selfup commented 8 years ago

I'll run this on Ubuntu 14.04 and Fedora 23 on a three year old ASUS laptop with an i7.

Darwin already ran faster on the iters compared to W10. I am sure Linux will have better results

pindell-matt commented 8 years ago

Sorry for the delay - this all looks great, merging now.

cite-reader commented 8 years ago

I have a recent Thinkpad with an i7 processor... and no spinning disks whatsoever. The solid-state hard drive probably has a bit of an effect on filesystem performance.