pindexis / marker

The terminal command palette
MIT License
2.02k stars 106 forks source link

Readme inconsitency. #2

Closed CMLL closed 9 years ago

CMLL commented 9 years ago

In the README you put Ctrl-Space as the default key binding to invoke marker get, but looking at the code, is actually Ctrl-@

marker_key_get=${MARKER_KEY_GET:-'\C-@'}

Just that. Great work, very useful.

pindexis commented 9 years ago

'@' refers to space.

Thanks for the feedback :)

CMLL commented 9 years ago

Uhm, pretty weird. In what OS are you trying it? I'm using Ubuntu 14.04 and what actually work with C-@ is Ctrl-@. Are you on OS-X? Other thing is that I'm using zsh, but for the comment in marker.sh I figured that wouldn't be the problem.

pindexis commented 9 years ago

I'm also on Ubuntu 14.04: In my case, \C-@ is identified by both Ctrl+Space and Ctr+@

Try running cat command and press on Ctrl+space. let me know the output.

Thanks.

CMLL commented 9 years ago

Nope, autocompletes with Ctrl-@, not with Ctrl-Space. I'm trying to remember if something I use sets Ctrl-Space as a keybing, and have a coworker installing marker to try and replicate.

CMLL commented 9 years ago

Ahh, another thing, when installing, git clone said I didn't had permissions, had to use http.

pindexis commented 9 years ago

I've updated Readme instructions to clone using https. Thanks

pindexis commented 9 years ago

I guess this can be closed now.