search

pine64 / OpenPineBuds

Community maintained firmware for PineBuds Pro
148 stars 18 forks source link

CMakeLists for utils, platform, and rtos targets #103

Closed nicka101 closed 2 months ago

nicka101 commented 4 months ago

In its current state, I don't attempt to cover the options/defines from the Makefiles (primarily just the targets themselves and their includes/links), and platform_cmsis seems to be the biggest blocker to compilation, representing the vast majority of the errors. The fact it doesn't build successfully is also the primary reason this PR is marked draft, though neither does the HEAD of the cmake branch, so feel free to merge this if you want

shymega commented 4 months ago

I'll review this this weekend. What I'll likely do is merge into cmake, and we can keep working on that branch. If it's better for you, and I could grant you access to my fork on that branch.

@Ralim I will handle this PR =)

nicka101 commented 4 months ago

I'll review this this weekend

Cool, no rush. I mostly opened this so we can avoid redoing the same work separately

What I'll likely do is merge into cmake, and we can keep working on that branch

Makes sense, and is the target branch for this PR anyway :)

If it's better for you, and I could grant you access to my fork on that branch.

Up to you, I don't mind working via PR, but it might be easier with push access to cmake. If you've got a preferred platform outside of Github for coordinating our efforts, let me know

shymega commented 2 months ago

Sorry for the delay in review. I've got round to it now.

shymega commented 2 months ago

@Ralim I've requested your review here - would like to get your clearance on this PR.

Ralim commented 2 months ago

@shymega cmake isn't my forte so happy to leave primary review to you.

shymega commented 2 months ago

@Ralim Thanks, will do.

shymega commented 2 months ago

@nicka101 I've rebased your branch, and applied the fixes. I'm keen to get this into my branch as soon as possible, and I'm especially grateful for your work here.

Would you agree that squashing the commits in this PR would be a good idea?

Cheers.

nicka101 commented 2 months ago

By all means, do whatever you see fit to manage the branch. I haven't had much time to work on this lately, hopefully I'll have some more soon, but I can always pull/rebase as needed

shymega commented 2 months ago

@nicka101 Alright. I'll merge this now, so we can progress with the CMake conversion.

Many thanks for your contribution! Anything else, feel free to open more PRs - we could sure use it!