search

pine64 / OpenPineBuds

Community maintained firmware for PineBuds Pro
141 stars 18 forks source link

Don't flash blue LED when connected to bluetooth #48

Closed FintasticMan closed 1 year ago

FintasticMan commented 1 year ago

Maybe this is just me, feel free to close this if it is, but I really dislike the flashing of the blue light when the buds are connected. I think it's completely unnecessary and even a bit confusing.

This seemed to work if I completely removed the code in the APP_STATUS_INDICATION_CONNECTED case, but that seems to me like it would just keep the LED in the state it is in before it connected. Let me know if that assumption is wrong.

Ralim commented 1 year ago

Would it be possible to make this a build flag instead? (ie. flag and then enable or not based on that) I'm in the camp of wanting the status indication as it makes development easier at times; but I can definitely see both sides to this.

FintasticMan commented 1 year ago

I've implemented a compile-time option for it, and it defaults to disabling the blue light. Is that alright?

FintasticMan commented 1 year ago

@Ralim Are there any changes to this I should make to get it merged?

Ralim commented 1 year ago

Nagging me is generally a good start 🤣