search

pine64 / bl_iot_sdk

BL602 SDK (Pine64 fork)
https://pine64.github.io/bl602-docs/
Apache License 2.0
134 stars 58 forks source link

Improved README.md #51

Closed n0toose closed 3 years ago

n0toose commented 3 years ago
Avamander commented 3 years ago

The variables have to be set if it can't guess them automatically, I wouldn't remove that section.

n0toose commented 3 years ago

The variables have to be set if it can't guess them automatically, I wouldn't remove that section.

I mean, is there any other option that could be chosen over instead?

Avamander commented 3 years ago

I mean, is there any other option that could be chosen over instead?

Elaborate.

n0toose commented 3 years ago

I mean, is there any other option that could be chosen over instead?

Elaborate.

There are options such as BL60X and BL606 for hal_drv, but they are not projected to be used due to the way that the Makefile's are written under customer_app. There's no way that any other option other than BL602, without the user explicitly desiring to do so.

For the same reason, I wouldn't understand why guessing the directory could go wrong under a Unix-like environment either.

Anything apart from that should be considered as an edge case and should be documented differently, IMHO. (I can take care of that as well, if necessary.)

Avamander commented 3 years ago

For the same reason, I wouldn't understand why guessing the directory could go wrong under a Unix-like environment either.

It assumes the examples are inside the SDK folder, this would break when someone copies an example out and doesn't set the variable. The documentation would be better if it mentioned this nuance.

n0toose commented 3 years ago

For the same reason, I wouldn't understand why guessing the directory could go wrong under a Unix-like environment either.

It assumes the examples are inside the SDK folder, this would break when someone copies an example out and doesn't set the variable. The documentation would be better if it mentioned this nuance.

Will correct in a bit.

n0toose commented 3 years ago

Fixed the conflict.