search

pine64 / bl_iot_sdk

BL602 SDK (Pine64 fork)
https://pine64.github.io/bl602-docs/
Apache License 2.0
134 stars 59 forks source link

Add Mbed TLS Submodule #64

Closed danielbarry closed 3 years ago

danielbarry commented 3 years ago

Updated to the latest release of medtls, builds (for me) but needs testing on hardware.

It's not really possible to figure out the commit @bouffalolab uses as this code is based on AliOS-Things [1] and they in turn don't mention which commit of mbedtls they use [2].

[1] https://github.com/bouffalolab/bl_iot_sdk/blob/ee4a10b1a1e3609243bd5e7b3a45f02d768f6c14/components/security/mbedtls/version

[2] https://github.com/alibaba/AliOS-Things/commit/0f445ed580f9a521a31772a8cf8420e358f3fb93#diff-4b5520f6bf4cbfda2bccddac70d010ff7cc379d1655a3072dd0e048dbfc69ed7

danielbarry commented 3 years ago

This is suggested in context of the comments for this PR: https://github.com/pine64/bl_iot_sdk/pull/61

danielbarry commented 3 years ago

@Avamander Added the space, I guess we'll see what happens.

danielbarry commented 3 years ago

Has anybody had a chance to test this in hardware?

Avamander commented 3 years ago

Hate to bother you this much, but it might be a good idea to also mention in bold in the README.md that clone has to be done with submodules.

danielbarry commented 3 years ago

@Avamander Updated that. Also if you're happy with the "Changes requested" part are you able to accept them?

gamelaster commented 3 years ago

@danielbarry Thank you very much. Your pull request will be merged when after testing. Since your PR is reviewed, you can apply for free EVB. For receiving the free PineCone, please sign up at this link. (If there will be any issues with signing up, please let me know here).

gamelaster commented 3 years ago

Well, since this PR triggered the CI and the CI works finely, I think we can merge it right now

danielbarry commented 3 years ago

@gamelaster Just resolved the README.rst merge conflict, so it should be good to go