Fix CI ignoring build errors

pine64 / bl_iot_sdk

BL602 SDK (Pine64 fork)

https://pine64.github.io/bl602-docs/

Apache License 2.0

134 stars 58 forks source link

Fix CI ignoring build errors #78

Closed ftk closed 3 years ago

ftk commented 3 years ago

The customer_app/Makefile returns success status even if one of the build scripts failed. Since CI (https://github.com/pine64/bl_iot_sdk/pull/68) uses it it always succeeds even if there were errors during compilation.

gamelaster commented 3 years ago

Hi @ftk, thank you very much for this! We should disable some examples since they cannot be compiled (missing some deps).

ftk commented 3 years ago

It seems the errors appear after this 2aa0fdd6b6251544321dfef963cef58350598d1b commit. I enabled submodules in workflow: https://github.com/ftk/bl_iot_sdk/commit/9572d0c2f75a2880615946beb4ac61349bcb1419 but it doesn't seem to help for some reason. EDIT: wrong commit

ftk commented 3 years ago

Seems like some .mk files got deleted in this commit which prevent mbedtls compilation by make: https://github.com/pine64/bl_iot_sdk/commit/2aa0fdd6b6251544321dfef963cef58350598d1b#diff-0574a24798cb143ae60c9a722a85ac6ccb3f3b219e9c3c692ed345f70cc30f21

gamelaster commented 3 years ago

Ah yes. I will try to fix it. Thanks for finding out the issue 😊