search

pine64 / bl_iot_sdk

BL602 SDK (Pine64 fork)
https://pine64.github.io/bl602-docs/
Apache License 2.0
134 stars 58 forks source link

Fix GCC warnings #84

Open lupyuen opened 3 years ago

lupyuen commented 3 years ago

This PR fixes the warnings in BL602 HAL generated by xpack-riscv-none-embed-gcc 8.3.0-2.3 when building for Mynewt OS. The warnings were due to buffer overflow, mismatched types, missing declarations and variables set but not used.

tchebb commented 3 years ago

These changes look good, thanks! Do you mind squashing the commits together? I'm generally in favor of as granular commits as possible, but one commit per line change seems a little excessive :) (I can also just merge with squash if you prefer that, but you won't have control over the final commit message if I do it that way.)

lupyuen commented 3 years ago

Yes could you please merge with squash for me thanks! I haven't done squashing before and I'll probably mess it up 🙂