Switch purple and yellow colors

[albandewilde]

I have notice the purple and yellow colors have been switched on the Window Terminal configuration.

[pineapplegiant]

Hey good catch! Yeahh, this has come up in the past. I moved the repositories and I messed up the history and forgot to update this on the READMEs as a known thing.

I haven’t personally tested the Windows theme, but if you look at the other themes closely, you’ll see the same thing pop up on the alacritty.yml etc. It’s non intuitive, but I liked how the purple looked in that spot.

Let me know with a screenshot if you prefer the other way. I’ll likely post some screenshots later too and pin this.

[albandewilde]

Here is the original windows terminal theme:

This is the original theme of spaceduck:

This is the modified theme of spaceduck:

I think it's preferable to let the yellow be yellow because any terminal application that use ansi escape sequence for color will change due to the theme.
I understand that a theme should change colors, but changing the yellow as purple and the purple as yellow could be a hard change.

[pineapplegiant]

I really appreciate your PR! But I think it makes better sense to change all of the terminal themes if I'm going to make this change. All of the yellow is purple in the other terminals.

I think a better change, which I'll do later today is just to have this in the README and let users modify their color schemes individually if they prefer, but I like having the purple in that screenshot since this is more of a purple based theme.