pineapplegiant / spaceduck-terminal

🚀 🦆Spaceduck theme but for terminal!
MIT License
99 stars 11 forks source link

Bright and normal colours are identical #8

Open ojdo opened 3 years ago

ojdo commented 3 years ago

I very much enjoy the overall look of this colour scheme, but had to disable it due to normal and bright colours being identical. This correcting commit 00eaad35db62b554094774d48e12f9fb3ba21775 makes me believe that this is not accidental but intentional. Is there a chance to have all 16 colours distinct?

Breaking for me is the mail view in MUA alot, for which all mail header lines become invisible with SpaceDuck active.

pineapplegiant commented 3 years ago

Do you mind providing a screenshot? I can totally change those colors, I truthfully don’t know how the bright colors work. The purple and yellow was the only intentional change. I’ll see if I can come up with something good

ojdo commented 3 years ago

Here is a pair of screenshots with the difference in appearance between Campbell and SpaceDuck:

Campbell

grafik

SpaceDuck

grafik

And just for reference, why it occurs in alot: its default theme uses dark and light gray for foreground/background of header_value (i.e. the field contents).

kmuncie commented 2 years ago

I would agree, there should be a distinction between normal and bright colors. I ended up adjusting the Windows Terminal color scheme in order to resolve the issues I was having. Here is the config I ended on and some examples from before and after through neofetch.

        {
            "name": "SpaceDuck",
            "cursorColor": "#f2ce00",
            "selectionBackground": "#f2ce00",
            "foreground": "#ecf0c1",
            "background": "#0f111b",
            "black": "#000000",
            "red": "#d36240",
            "green": "#5ccc96",
            "yellow": "#b3a1e6",
            "blue": "#6d3c8a",
            "purple": "#c0aa2e",
            "cyan": "#00a3cc",
            "white": "#c9cca9",
            "brightBlack": "#686f9a",
            "brightRed": "#e33400",
            "brightGreen": "#51eea2",
            "brightYellow": "#9d79ff",
            "brightBlue": "#9630d1",
            "brightPurple": "#f2ce00",
            "brightCyan": "#19c5f0",
            "brightWhite": "#fafce0"
        }

Repo color scheme: before

My custom color scheme changes: after2

pineapplegiant commented 2 years ago

This looks pretty good. I'll have to test and add this in. If it works, it'd be good to update all the other configs as well. I've heard some complaints from others regarding this issue. Thanks for this @kmuncie ! 🚀 🦆