Closed Eliot00 closed 3 years ago
Is this Airline? Yeah that looks busted lol.
I’ll fix it this weekend. I haven’t tested Airline just light line.
Is this Airline? Yeah that looks busted lol.
I’ll fix it this weekend. I haven’t tested Airline just light line.
Yes it's Airline, and thanks for your nice work on the theme.
I've had this same issue, which is when you have let g:airline#extensions#tabline#enabled = 1
on, which shows buffers as well as tabs.
Normally, spaceduck looks great as usual with that setting off:
But for some reason with let g:airline#extensions#tabline#enabled = 1
, the colors are messed up, just like yours:
I might look into fixing these colors myself this evening. I'll let you know if I make some progress.
UPDATE: I added this to spaceduck/autoload/airline/themes/spaceduck.vim
" tabline colors
let s:tab_background = [ "#ecf0c1", "#0f111b", 255, 233]
let s:selected_tab = [ "#000000", "#686f9a", 237, 60 ]
let s:background_tab = [ "#686f9a", "#30365F", 146, 0 ]
" reference airline-tabline-hlgroups
let g:airline#themes#spaceduck#palette.tabline = {
\ "airline_tab": s:background_tab,
\ "airline_tab_right": s:background_tab,
\ "airline_tabsel": s:selected_tab,
\ "airline_tabsel_right": s:selected_tab,
\ "airline_tabfill": s:tab_background,
\ }
When changes have been made to the file:
Let me know what you guys think. I was following the Airline colors used, but I'd appreciate your feedback.
UPDATE: I added this to spaceduck/autoload/airline/themes/spaceduck.vim
" tabline colors let s:tab_background = [ "#ecf0c1", "#0f111b", 255, 233] let s:selected_tab = [ "#000000", "#686f9a", 237, 60 ] let s:background_tab = [ "#686f9a", "#30365F", 146, 0 ] " reference airline-tabline-hlgroups let g:airline#themes#spaceduck#palette.tabline = { \ "airline_tab": s:background_tab, \ "airline_tab_right": s:background_tab, \ "airline_tabsel": s:selected_tab, \ "airline_tabsel_right": s:selected_tab, \ "airline_tabfill": s:tab_background, \ }
When changes have been made to the file:
Let me know what you guys think. I was following the Airline colors used, but I'd appreciate your feedback.
I like this, thank you.
Thanks for this!
Yeah I think this might be a bug with these lines in the raw colorscheme, let me play with it before adding this in the airlines theme.
I switched to using bar bar and have this for my tabline, so hopefully I can recreate, as I like the smooth blended look into the background. But the tabline you have looks very bright and good as well.
I think your smooth blended look is better. The original colors I used was because it matches the the bottom Airline status bar.
So I tried using the barbar colors from your screenshot for the Airline tabs, but it doesn't look as pretty.
This is how the barbar look translates:
This is probably because barbar makes the tabs follow a modern GUI look while Airline tabs are simply functional (also separates buffers and tabs).
I think the Airline tabs look better with a purple highlight:
I also made it so that when the file is modified, the tab is that beautiful spaceduck green:
(I can't stress enough how much I love the spaceduck colors.)
Let me know what you think. Should I create a pull request with my changes?
This looks perfect oh my goodness! Apologies for taking so long on this.
Yes I would very much like this in the theme!
I can do it or if you prefer to submit a PR, for recognition I'll gladly accept it. To make these changes, you'd want to edit the /spaceduck/blob/main/estilo/syntax/base.yml
along with the base spaceduck file if you don't want to install the estilo dependency locally.
The Airline status bar and tab line both have been fixed and are ready for release. Currently, it is in the dev branch.
Thanks for reporting the issue!
Not sure if it’s a bug, but it looks too dark