pineapplegiant / spaceduck

🚀 🦆 An intergalactic space theme for Vim, Terminal, and more!
https://pineapplegiant.github.io/spaceduck/
MIT License
813 stars 29 forks source link

Missing highlighting in TypeScript #3

Closed Tomburgs closed 3 years ago

Tomburgs commented 3 years ago

Hey, I love the color scheme, but there are some issues with it when working with TypeScript / TypeScript React.

Here's some of the issues I've encountered:

Here's screenshots for comparison

Default default

Spaceduck spaceduck

It seems like the typescriptVariable / typescriptType / etc Vim values need to be linked to the correct definitions, however, I'm not sure how this works with the Estilo workflow.

I'm also concerned about the color on comments or HTML brackets, as they are quite dark and a bit difficult to read / see. Perhaps there's something that can be done about this?

pineapplegiant commented 3 years ago

Oof yeah that is ugly.

Good find and these screenshots are great! I was able to recreate the error. I'll try to get this done in the next couple days as I need to standardize where colors go more consistently. Just curious, are you using a specific syntax plugin by any chance? Thanks again.

Tomburgs commented 3 years ago

Just curious, are you using a specific syntax plugin by any chance? Thanks again.

I do have vim-polyglot plugin installed which uses yats.vim, however it's now the default TypeScript highlighting in Vim & NeoVim, so there shouldn't be any issues without it.

pineapplegiant commented 3 years ago

@Tomburgs Just updated the branch with another commit hopefully that fixes the Typescript issue. (I think there's too much pink now), but go ahead and give that a try. I just updated the README with all of the locations of the colors too.

pineapplegiant commented 3 years ago
Screen Shot 2020-12-15 at 5 03 02 PM

Might change the pink braces in the JSX. But I'm gonna close this for now!